Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve replaceQueryParameters function for empty array #1144

Merged
merged 1 commit into from Mar 14, 2020
Merged

Improve replaceQueryParameters function for empty array #1144

merged 1 commit into from Mar 14, 2020

Conversation

VincentLanglet
Copy link
Contributor

Fix #1143

@ostrolucky
Copy link
Member

I think we shouldn't fix such superficial issue, but fix underlying problem - For some reason, bundle is not using SQLParserUtils::expandListParameters

ostrolucky
ostrolucky approved these changes Mar 14, 2020
View reviewed changes
Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've investigated possibility to replace our mechanism with SqlParserUtils::expandListParameters. Unfortunately behaviour of this DBAL function is different than we need for named parameters without array_ types 1, 2. So this is good to go. Just made very minor improvement since I had branch already checked out.

@greg0ire greg0ire added the Bug label Mar 14, 2020
@greg0ire greg0ire merged commit efc5ed4 into doctrine:master Mar 14, 2020
@greg0ire
Copy link
Member

Thanks @VincentLanglet !

@ostrolucky ostrolucky added this to the 1.12.8 milestone Mar 14, 2020
@ostrolucky ostrolucky self-assigned this Mar 14, 2020
@ostrolucky ostrolucky modified the milestones: 1.12.8, 2.1.0 Mar 14, 2020
@VincentLanglet VincentLanglet mentioned this pull request Apr 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostrolucky ostrolucky ostrolucky approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees

@ostrolucky ostrolucky

Labels
Bug
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Profiler give a non-executable query when using empty array.
3 participants
@VincentLanglet @ostrolucky @greg0ire